Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui/tray: Fix activity icon colours #7567

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

claucambra
Copy link
Collaborator

Fixes colouring of activity icons in dark mode as well as in dark/light mode switch

Fixes #7560

@claucambra claucambra self-assigned this Nov 26, 2024
@claucambra claucambra added this to the 3.15.1 milestone Nov 26, 2024
@claucambra
Copy link
Collaborator Author

/backport to stable-3.15

@claucambra claucambra changed the title Bugfix/activity icon colours gui/tray: Fix activity icon colours Nov 28, 2024
@mgallien mgallien force-pushed the bugfix/activity-icon-colours branch from 5c54529 to 2f020a0 Compare December 9, 2024 08:11
…vider based urls with no colouring

Signed-off-by: Claudio Cambra <[email protected]>
…t model

We can just colour the relevant activity icon from QML based on the
palette text colour

Signed-off-by: Claudio Cambra <[email protected]>
@mgallien mgallien force-pushed the bugfix/activity-icon-colours branch from 2f020a0 to d921411 Compare December 9, 2024 10:11
@mgallien mgallien merged commit d8f1df9 into master Dec 9, 2024
11 of 14 checks passed
@mgallien mgallien deleted the bugfix/activity-icon-colours branch December 9, 2024 10:11
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7567-d921411bd3d21bc6761f80c7692452a3e6948feb-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarqubecloud bot commented Dec 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: macOS dark mode: wrong color for icons in active file interaction list
3 participants